Add client for erdbeere #748
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Init coffee TODO list (for conversion) * Show number of lines in coffee TODO list * Sort list according to number of lines in coffee files * Remove import_manuscript.coffee * Replace deprecated location.reload(true) with cache busting * Delete error.coffee * Replace subscription swatch coffee by JS * Replace location.reload() in identify.coffee * Decaffeinate update for answers (in lecture edit mode) * Decaffeinate delete_edge * Delete new.coffee * Decaffeinate default target update in quiz * Decaffeinate cancel edit tags (erdbeere) * Decaffeinate display_info (for erdbeere) * Decaffeinate edit tags * Decaffeinate delete_account modal rendering * Decaffeinate cancel_edit tutorials * Add watch out for section * Decaffeinate validate certificate (tutorials) * Decaffeinate cancel edit assignment * Decaffeinate cancel_import_media (Reset button) * Decaffeinate cancel_action as tutor (e.g. move to another tut) * Decaffeinate cancel_edit_correction (as tutor) * Decaffeinate validate quiz certificates (as tutor) * Decaffeinate new vertex (in quiz) * Delete render_sidebar * Decaffeinate late submission accept * Decaffeinate reject submission (as tutor) * Decaffeinate refresh_token (for submissions as tutor) * Add 😭 emoji
fosterfarrell9
requested a deployment
to
testing-review
GitHub Actions
Waiting
|
@fosterfarrell9 Could you merge the dev branch first into this one? It seems there is some divergence, e.g. the coffee file etc. You might have not yet pulled the new dev branch. |
This reverts commit 7de7f0f.
Splines
requested a deployment
to
testing-review
GitHub Actions
Waiting
Splines
requested a deployment
to
testing-review
GitHub Actions
Waiting
fosterfarrell9
requested a deployment
to
testing-review
GitHub Actions
Waiting
Splines
requested changes
Feb 16, 2025
There was a problem hiding this comment.
Nice, this works like a charm, thanks! Here some further comments. I've also reviewed the respective erdbeere PR. The erdbeere PR must be merged before this one.
Comment on lines
+3
to
+5
| ERDBEERE_CONNECTION = Faraday.new(url: ERDBEERE_API_URL) do |conn| | ||
| conn.adapter(Faraday.default_adapter) | ||
| end |
There was a problem hiding this comment.
⚠ In production, how does MaMpf communicate with the Erdbeere server? Is Erdbeere just available on localhost or also available to the word-wide web. In the latter case, how does MaMpf authenticate at Erdbeere? I'm wondering in particular since Erdbeere itself has a frontend which allows to log in.
fosterfarrell9
requested a deployment
to
testing-review
GitHub Actions
Waiting
fosterfarrell9
requested a deployment
to
testing-review
GitHub Actions
Waiting
Splines
approved these changes
Feb 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We add a client for the erdbeere API. The main point is to establish communication in development between a local installation of erdbeere and a local installation of mampf. In order to be able to do that, some headers have to be modified, so we wrote a small wrapper for that (in production it does basically nothing, i.e. the header is not modified).
Respective PR on the erdbeere side: MaMpf-HD/erdbeere#4
Warning
Merge the Erdbeere PR first, then this PR.